Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP errors and status codes to site breakage reports #2205

Merged
merged 13 commits into from
Feb 23, 2024

Conversation

SlayterDev
Copy link
Contributor

@SlayterDev SlayterDev commented Feb 14, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1206604819945148/f
Tech Design URL:
CC:

Description:

Steps to test this PR:

  1. Load https://google.com/invalid
  2. Set a breakpoint on Line 240 of PrivacyDashboardViewController.swift and send a breakage report
  3. Validate that the report contains httpErrorCodes

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@SlayterDev SlayterDev self-assigned this Feb 14, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Feb 14, 2024
@github-actions github-actions bot added bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project and removed bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project labels Feb 15, 2024
@SlayterDev SlayterDev removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Feb 15, 2024
@SlayterDev SlayterDev marked this pull request as ready for review February 15, 2024 18:59
@SlayterDev SlayterDev merged commit b565485 into main Feb 23, 2024
16 of 17 checks passed
@SlayterDev SlayterDev deleted the brad/error-code-updates branch February 23, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants